Detect bidir 5665 v9 #10818
Closed
Detect bidir 5665 v9 #10818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: 5665 This is done with `alert ip any any => any any` The => operator means that we will need both directions
By using keywords bidir.toclient and bidir.toserver, the following keywords are forced to the direction even if they can match on both directions. Ticket: 5665
Closed
|
cc @zoomequipd |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10818 +/- ##
==========================================
- Coverage 82.75% 82.67% -0.09%
==========================================
Files 928 928
Lines 247913 248044 +131
==========================================
- Hits 205162 205064 -98
- Misses 42751 42980 +229
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 20053 |
Closed
|
Continued in #10904 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/5665
Describe changes:
OISF/suricata-verify#1758
Draft again because of second commit
General feedback expected :-)
TODO :
bidir.toclient?only_tsonly if the keyword is ambiguous ?#10685 with additional commit to get fast_pattern toclient for bidirectional signatures